X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=TODO;h=37857feb7015fb6501f11ad3eb43fb59b26389d1;hb=5de9c7132d616bcf1ef348a243ac2eb057b63424;hp=f8dc544d5af8234867f339f6dc653e322bfb1b38;hpb=0e160a665eeb24d4614ff14e779d1c13bec3e778;p=open-adventure.git diff --git a/TODO b/TODO index f8dc544..37857fe 100644 --- a/TODO +++ b/TODO @@ -7,7 +7,13 @@ remain to be cleaned up: rather promiscuously to pass around information that ought to be function arguments in a modern language. K and SPK are particular offenders -* Remaining unstructured gotos in playermove() and do_command(). +* Remaining unstructured gotos in playermove() and do_command(). The goto L12 + in playermove() is particularly horrible, jumping backwards into the + middle of a loop. + +* In playermove(), why doesn't replacing the global motion number K + with a passed-in argument work? There's some unobvious information + leak here. * The way return values from handlers such as 2012 trigger side effects based on global state such as K and SPK is nasty.