X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=TODO;h=37857feb7015fb6501f11ad3eb43fb59b26389d1;hb=43032763cdb923c2b8328933acfe6efeaced3bbd;hp=681e95987ca2f0055b91a4e2a19a1b852cfcc93e;hpb=8a8770375ebcf69b18749be85838dc46132cbe9f;p=open-adventure.git

diff --git a/TODO b/TODO
index 681e959..37857fe 100644
--- a/TODO
+++ b/TODO
@@ -1,12 +1,21 @@
 = Open Adventure TODO =
 
-* Update the command parser to accept a PRNG seed value.
+The FORTRANish mess that once was is now mostly idiomatic C. Some issues
+remain to be cleaned up:
 
-* Add command log replay.  Note that the replay log needs to begin
-  with the random-number seed.
+* The remaining shared globals: K, SPK, WD1, WD1X, WD2, WD2X. These are used
+  rather promiscuously to pass around information that ought to be function
+  arguments in a modern language. K and SPK are particular offenders
 
-* Use that feature to make regression tests from walkthroughs.
+* Remaining unstructured gotos in playermove() and do_command(). The goto L12
+  in playermove() is particularly horrible, jumping backwards into the
+  middle of a loop.
+
+* In playermove(), why doesn't replacing the global motion number K
+  with a passed-in argument work? There's some unobvious information
+  leak here.
+
+* The way return values from handlers such as 2012 trigger side effects
+  based on global state such as K and SPK is nasty.
 
-* Translate the FORTRANish mess to actual C.
 
-* Inline the database so the code doesn't need an external file.