X-Git-Url: https://jxself.org/git/?a=blobdiff_plain;f=TODO;h=218ca91a68841d75ee690b20fd5d188dbc0c3ed8;hb=95f1548a10d4e64b5494663e25fbe881a80852eb;hp=c4102f2bb274abe0f5ef523cd9284eac17c8a815;hpb=a062d43079d42716ab682f04e5a94c97d1527cba;p=open-adventure.git diff --git a/TODO b/TODO index c4102f2..218ca91 100644 --- a/TODO +++ b/TODO @@ -5,17 +5,13 @@ remain to be cleaned up: * The remaining shared globals: K, WD1, WD1X, WD2, WD2X. These are used rather promiscuously to pass around information that ought to be function - arguments in a modern language. K is a particular offender + arguments in a modern language. K is a particular offender. * Remaining unstructured gotos in playermove() and do_command(). The goto L12 in playermove() is particularly horrible, jumping backwards into the middle of a loop. -* In playermove(), why doesn't replacing the global motion number K - with a passed-in argument work? There's some unobvious information - leak here. - * The way return values from handlers such as 2012 trigger side effects - based on global state such as K and SPK is nasty. + based on global state is nasty.